From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzmPu-00026C-4C for qemu-devel@nongnu.org; Sun, 05 Jan 2014 07:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzmPo-0005DD-Oo for qemu-devel@nongnu.org; Sun, 05 Jan 2014 07:02:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzmPo-0005D7-Gs for qemu-devel@nongnu.org; Sun, 05 Jan 2014 07:02:48 -0500 From: Amos Kong Date: Sun, 5 Jan 2014 20:02:29 +0800 Message-Id: <1388923351-10556-2-git-send-email-akong@redhat.com> In-Reply-To: <1388923351-10556-1-git-send-email-akong@redhat.com> References: <1388923351-10556-1-git-send-email-akong@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/3] qapi: cleanup redundant variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, qiaonuohan@cn.fujitsu.com, xiawenc@linux.vnet.ibm.com, lcapitulino@redhat.com No need to re-append an expr list, it's ok to return schema.exprs Signed-off-by: Amos Kong --- scripts/qapi.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 750e9fb..4263bbd 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -165,8 +165,6 @@ def parse_schema(fp): print >>sys.stderr, e exit(1) - exprs = [] - for expr in schema.exprs: if expr.has_key('enum'): add_enum(expr['enum']) @@ -175,9 +173,8 @@ def parse_schema(fp): add_enum('%sKind' % expr['union']) elif expr.has_key('type'): add_struct(expr) - exprs.append(expr) - return exprs + return schema.exprs def parse_args(typeinfo): if isinstance(typeinfo, basestring): -- 1.8.4.2