From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzs1E-0004vQ-EU for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vzs16-0004ps-PX for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:48 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:52775 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzs16-0004oD-CH for qemu-devel@nongnu.org; Sun, 05 Jan 2014 13:01:40 -0500 From: Peter Lieven Date: Sun, 5 Jan 2014 19:02:30 +0100 Message-Id: <1388944951-14767-6-git-send-email-pl@kamp.de> In-Reply-To: <1388944951-14767-1-git-send-email-pl@kamp.de> References: <1388944951-14767-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv3 5/6] ui/vnc: optimize setting in vnc_dpy_update() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, Peter Lieven , aliguori@amazon.com Signed-off-by: Peter Lieven --- ui/vnc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 980df34..805c47a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd); static void vnc_dpy_update(DisplayChangeListener *dcl, int x, int y, int w, int h) { - int i; VncDisplay *vd = container_of(dcl, VncDisplay, dcl); struct VncSurface *s = &vd->guest; int width = surface_width(vd->ds); @@ -451,9 +450,8 @@ static void vnc_dpy_update(DisplayChangeListener *dcl, h = MIN(h, height); for (; y < h; y++) { - for (i = 0; i < w; i += VNC_DIRTY_PIXELS_PER_BIT) { - set_bit((x + i) / VNC_DIRTY_PIXELS_PER_BIT, s->dirty[y]); - } + bitmap_set(s->dirty[y], x / VNC_DIRTY_PIXELS_PER_BIT, + w / VNC_DIRTY_PIXELS_PER_BIT); } } -- 1.7.9.5