From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 2/2] PPC: KVM: fix "set one register"
Date: Mon, 6 Jan 2014 16:36:40 +1100 [thread overview]
Message-ID: <1388986600-26301-3-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1388986600-26301-1-git-send-email-aik@ozlabs.ru>
Due to missing @one_reg_id assignment in _spr_register(),
the kvm_get_one_reg/kvm_set_one_reg API has never really been working.
This enabled the API and removes use of the API for LPCR as
kvm_arch_get_registers/kvm_arch_put_registers run a loop for all 1024 SPR
and LPCR is one of them.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
target-ppc/translate_init.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 144de3d..149a932 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -628,6 +628,9 @@ static inline void _spr_register(CPUPPCState *env, int num,
spr->oea_read = oea_read;
spr->oea_write = oea_write;
#endif
+#if defined(CONFIG_KVM)
+ spr->one_reg_id = one_reg_id,
+#endif
env->spr[num] = initial_value;
}
--
1.8.4.rc4
next prev parent reply other threads:[~2014-01-06 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 5:36 [Qemu-devel] [PATCH 0/2] PPC: KVM: fix set_one_reg Alexey Kardashevskiy
2014-01-06 5:36 ` [Qemu-devel] [PATCH 1/2] target-ppc: fix Authority Mask Register init value Alexey Kardashevskiy
2014-01-06 17:29 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2014-01-06 5:36 ` Alexey Kardashevskiy [this message]
2014-01-06 6:40 ` [Qemu-devel] [PATCH 2/2] PPC: KVM: fix "set one register" Alexey Kardashevskiy
2014-01-06 18:23 ` [Qemu-devel] [RFC] PPC: KVM: add support for LPCR Greg Kurz
2014-01-09 13:02 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-01-06 17:30 ` [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: KVM: fix "set one register" Greg Kurz
2014-01-09 12:59 ` [Qemu-devel] [PATCH 0/2] PPC: KVM: fix set_one_reg Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388986600-26301-3-git-send-email-aik@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).