From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>, qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org
Subject: Re: [PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive
Date: Wed, 15 Nov 2023 15:45:17 -0500 [thread overview]
Message-ID: <1388a0c0-cfc2-4957-9bce-08499e9ac84d@xen.org> (raw)
In-Reply-To: <20231115172723.1161679-4-dwmw2@infradead.org>
On 15/11/2023 12:24, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Coverity couldn't see that nr_existing was always going to be zero when
> qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906).
>
> Perhaps more to the point, neither could Peter at first glance. Improve
> the code to hopefully make it clearer to Coverity and human reviewers
> alike.
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> hw/block/xen-block.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
>
Reviewed-by: Paul Durrant <paul@xen.org>
prev parent reply other threads:[~2023-11-15 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:24 [PATCH 0/3] Misc fixes for 8.2 David Woodhouse
2023-11-15 17:24 ` [PATCH 1/3] net: do not delete nics in net_cleanup() David Woodhouse
2023-11-15 17:24 ` [PATCH 2/3] vl: disable default serial when xen-console is enabled David Woodhouse
2023-11-21 10:57 ` Marc-André Lureau
2023-11-21 10:58 ` Marc-André Lureau
2023-11-21 11:42 ` David Woodhouse
2023-11-21 10:59 ` Paul Durrant
2023-11-15 17:24 ` [PATCH 3/3] hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive David Woodhouse
2023-11-15 20:45 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388a0c0-cfc2-4957-9bce-08499e9ac84d@xen.org \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=dwmw2@infradead.org \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).