From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W08Ou-0000TF-5P for qemu-devel@nongnu.org; Mon, 06 Jan 2014 06:31:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W08Os-0004R5-UX for qemu-devel@nongnu.org; Mon, 06 Jan 2014 06:31:20 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:44223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W08Os-0004QZ-OK for qemu-devel@nongnu.org; Mon, 06 Jan 2014 06:31:18 -0500 From: Peter Maydell Date: Mon, 6 Jan 2014 11:30:50 +0000 Message-Id: <1389007857-14649-46-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1389007857-14649-1-git-send-email-peter.maydell@linaro.org> References: <1389007857-14649-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PULL 45/52] char/cadence_uart: Delete redundant rx rst logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno From: Peter Crosthwaite uart_rx_reset() called immediately above already does this. Remove. Signed-off-by: Peter Crosthwaite Message-id: 05e30826496cf2579084ed801ac0b2c0d0a3071f.1388626249.git.peter.crosthwaite@xilinx.com Signed-off-by: Peter Maydell --- hw/char/cadence_uart.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index be32126..8a9ef81 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -438,8 +438,6 @@ static void cadence_uart_reset(DeviceState *dev) uart_rx_reset(s); uart_tx_reset(s); - s->rx_count = 0; - s->rx_wpos = 0; uart_update_status(s); } -- 1.8.5