From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0IGj-0008OI-Dz for qemu-devel@nongnu.org; Mon, 06 Jan 2014 17:03:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0IGa-0000xO-Ha for qemu-devel@nongnu.org; Mon, 06 Jan 2014 17:03:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0IGa-0000x1-9b for qemu-devel@nongnu.org; Mon, 06 Jan 2014 17:03:24 -0500 From: Luiz Capitulino Date: Mon, 6 Jan 2014 17:03:05 -0500 Message-Id: <1389045795-18706-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1389045795-18706-1-git-send-email-lcapitulino@redhat.com> References: <1389045795-18706-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PULL 04/14] qom: fix leak for objects created with -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: qemu-devel@nongnu.org From: Paolo Bonzini The object must be unref-ed when its variable goes out of scope. Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov Signed-off-by: Luiz Capitulino --- vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 0f67545..2170a5e 100644 --- a/vl.c +++ b/vl.c @@ -2810,12 +2810,13 @@ static int object_create(QemuOpts *opts, void *opaque) obj = object_new(type); if (qemu_opt_foreach(opts, object_set_property, obj, 1) < 0) { + object_unref(obj); return -1; } object_property_add_child(container_get(object_get_root(), "/objects"), id, obj, NULL); - + object_unref(obj); return 0; } -- 1.8.1.4