From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmT-0003ES-C0 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dmO-0003aU-MW for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:45 -0500 Received: from mail-qe0-x230.google.com ([2607:f8b0:400d:c02::230]:62866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmO-0003aK-Gx for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:40 -0500 Received: by mail-qe0-f48.google.com with SMTP id gc15so958159qeb.7 for ; Tue, 07 Jan 2014 13:01:39 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Tue, 7 Jan 2014 13:00:04 -0800 Message-Id: <1389128439-10067-15-git-send-email-rth@twiddle.net> In-Reply-To: <1389128439-10067-1-git-send-email-rth@twiddle.net> References: <1389128439-10067-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 14/49] target-i386: Fix typo in gen_push_T1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@amazon.com By inspection, obviously we should be storing T[1] not T[0]. This could only happen for x86_64 in 64-bit mode with 0x66 prefix to call insn -- i.e. never. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a1a23a6..9205b72 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2488,7 +2488,7 @@ static void gen_push_T1(DisasContext *s) gen_op_st_v(s, MO_64, cpu_T[1], cpu_A0); } else { gen_op_addq_A0_im(-2); - gen_op_st_v(s, MO_16, cpu_T[0], cpu_A0); + gen_op_st_v(s, MO_16, cpu_T[1], cpu_A0); } gen_op_mov_reg_A0(2, R_ESP); } else -- 1.8.4.2