From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dma-0003VP-R5 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0dmW-0003bp-4N for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:52 -0500 Received: from mail-qe0-x232.google.com ([2607:f8b0:400d:c02::232]:39666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0dmV-0003bb-Uw for qemu-devel@nongnu.org; Tue, 07 Jan 2014 16:01:48 -0500 Received: by mail-qe0-f50.google.com with SMTP id 1so936596qec.23 for ; Tue, 07 Jan 2014 13:01:47 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Tue, 7 Jan 2014 13:00:08 -0800 Message-Id: <1389128439-10067-19-git-send-email-rth@twiddle.net> In-Reply-To: <1389128439-10067-1-git-send-email-rth@twiddle.net> References: <1389128439-10067-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 18/49] target-i386: Use MO_BE for movbe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@amazon.com Fold the bswap into the memory operation. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-i386/translate.c | 40 +++++----------------------------------- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index cfd75dc..c07062c 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -3869,44 +3869,14 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b, ot = MO_64; } - /* Load the data incoming to the bswap. Note that the TCG - implementation of bswap requires the input be zero - extended. In the case of the loads, we simply know that - gen_op_ld_v via gen_ldst_modrm does that already. */ - if ((b & 1) == 0) { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 0); - } else { - switch (ot) { - case MO_16: - tcg_gen_ext16u_tl(cpu_T[0], cpu_regs[reg]); - break; - default: - tcg_gen_ext32u_tl(cpu_T[0], cpu_regs[reg]); - break; - case MO_64: - tcg_gen_mov_tl(cpu_T[0], cpu_regs[reg]); - break; - } - } - - switch (ot) { - case MO_16: - tcg_gen_bswap16_tl(cpu_T[0], cpu_T[0]); - break; - default: - tcg_gen_bswap32_tl(cpu_T[0], cpu_T[0]); - break; -#ifdef TARGET_X86_64 - case MO_64: - tcg_gen_bswap64_tl(cpu_T[0], cpu_T[0]); - break; -#endif - } - + gen_lea_modrm(env, s, modrm); if ((b & 1) == 0) { + tcg_gen_qemu_ld_tl(cpu_T[0], cpu_A0, + s->mem_index, ot | MO_BE); gen_op_mov_reg_T0(ot, reg); } else { - gen_ldst_modrm(env, s, modrm, ot, OR_TMP0, 1); + tcg_gen_qemu_st_tl(cpu_regs[reg], cpu_A0, + s->mem_index, ot | MO_BE); } break; -- 1.8.4.2