From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0k3Q-0002NM-Sa for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:43:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0k3K-0002aF-U7 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:43:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0k3K-0002aB-MJ for qemu-devel@nongnu.org; Tue, 07 Jan 2014 22:43:34 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s083hYBw011495 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 Jan 2014 22:43:34 -0500 From: Fam Zheng Date: Wed, 8 Jan 2014 11:42:48 +0800 Message-Id: <1389152570-1815-10-git-send-email-famz@redhat.com> In-Reply-To: <1389152570-1815-1-git-send-email-famz@redhat.com> References: <1389152570-1815-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v10 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng --- block/stream.c | 28 +--------------------------- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/block/stream.c b/block/stream.c index 46bec7d..9cdcf0e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -51,32 +51,6 @@ static int coroutine_fn stream_populate(BlockDriverState *bs, return bdrv_co_copy_on_readv(bs, sector_num, nb_sectors, &qiov); } -static void close_unused_images(BlockDriverState *top, BlockDriverState *base, - const char *base_id) -{ - BlockDriverState *intermediate; - intermediate = top->backing_hd; - - /* Must assign before bdrv_delete() to prevent traversing dangling pointer - * while we delete backing image instances. - */ - top->backing_hd = base; - - while (intermediate) { - BlockDriverState *unused; - - /* reached base */ - if (intermediate == base) { - break; - } - - unused = intermediate; - intermediate = intermediate->backing_hd; - unused->backing_hd = NULL; - bdrv_unref(unused); - } -} - static void coroutine_fn stream_run(void *opaque) { StreamBlockJob *s = opaque; @@ -190,7 +164,7 @@ wait: } } ret = bdrv_change_backing_file(bs, base_id, base_fmt); - close_unused_images(bs, base, base_id); + bdrv_drop_intermediate(bs, bs->backing_hd, base); } qemu_vfree(buf); -- 1.8.5.1