From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0q4l-0006SC-DW for qemu-devel@nongnu.org; Wed, 08 Jan 2014 05:09:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0q4f-0008HY-Dn for qemu-devel@nongnu.org; Wed, 08 Jan 2014 05:09:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0q4f-0008HT-5E for qemu-devel@nongnu.org; Wed, 08 Jan 2014 05:09:21 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s08A9KaC015696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Jan 2014 05:09:20 -0500 From: Fam Zheng Date: Wed, 8 Jan 2014 18:07:52 +0800 Message-Id: <1389175672-25109-12-git-send-email-famz@redhat.com> In-Reply-To: <1389175672-25109-1-git-send-email-famz@redhat.com> References: <1389175672-25109-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v11 11/11] block: Allow backup on referenced named BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be blocked by that. Signed-off-by: Fam Zheng --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index 1ceb852..c2e91a6 100644 --- a/block.c +++ b/block.c @@ -988,6 +988,8 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd) /* Otherwise we won't be able to commit due to check in bdrv_commit */ bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_COMMIT, bs->backing_blocker); + bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE, + bs->backing_blocker); pstrcpy(bs->backing_file, sizeof(bs->backing_file), bs->backing_hd->file->filename); pstrcpy(bs->backing_format, sizeof(bs->backing_format), -- 1.8.5.1