From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0vlc-0000bG-C8 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:14:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0vlU-0003X4-K2 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:14:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0vlU-0003Wl-D0 for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:13:56 -0500 From: Igor Mammedov Date: Wed, 8 Jan 2014 17:09:41 +0100 Message-Id: <1389197382-25085-5-git-send-email-imammedo@redhat.com> In-Reply-To: <1389197382-25085-1-git-send-email-imammedo@redhat.com> References: <1389197382-25085-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH 4/5] vl.c: -object: handle duplicate 'id' properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, sw@weilnetz.de, mjt@tls.msk.ru, lcapitulino@redhat.com, blauwirbel@gmail.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net object_property_add_child() may fail if 'id' matches already existing object. Which means incorrect command line, so instead of silently ignoring error, report it and go to error path (i.e. terminate QEMU). Signed-off-by: Igor Mammedov --- vl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 1620393..84cb7a8 100644 --- a/vl.c +++ b/vl.c @@ -2821,7 +2821,7 @@ static int object_create(QemuOpts *opts, void *opaque) } object_property_add_child(container_get(object_get_root(), "/objects"), - id, obj, NULL); + id, obj, &local_err); out: object_unref(obj); -- 1.7.1