From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1KRR-0005R1-JO for qemu-devel@nongnu.org; Thu, 09 Jan 2014 13:35:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1KRJ-0002eN-5x for qemu-devel@nongnu.org; Thu, 09 Jan 2014 13:34:53 -0500 From: Hani Benhabiles Date: Thu, 9 Jan 2014 19:34:27 +0100 Message-Id: <1389292467-5570-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH] net: Use g_strdup_printf instead of snprintf. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, stefanha@redhat.com, aliguori@amazon.com assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles --- net/net.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index 9db88cc..9363b35 100644 --- a/net/net.c +++ b/net/net.c @@ -164,7 +164,6 @@ void qemu_macaddr_default_if_unset(MACAddr *macaddr) static char *assign_name(NetClientState *nc1, const char *model) { NetClientState *nc; - char buf[256]; int id = 0; QTAILQ_FOREACH(nc, &net_clients, next) { @@ -176,9 +175,7 @@ static char *assign_name(NetClientState *nc1, const char *model) } } - snprintf(buf, sizeof(buf), "%s.%d", model, id); - - return g_strdup(buf); + return g_strdup_printf("%s.%d", model, id); } static void qemu_net_client_destructor(NetClientState *nc) -- 1.8.3.2