From: Steven Noonan <steven@uplinklabs.net>
To: qemu-devel@nongnu.org
Cc: Steven Noonan <snoonan@amazon.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 2/3] virtfs-proxy-helper.c: fix compile error
Date: Thu, 9 Jan 2014 13:55:07 -0800 [thread overview]
Message-ID: <1389304508-10100-2-git-send-email-steven@uplinklabs.net> (raw)
In-Reply-To: <1389304508-10100-1-git-send-email-steven@uplinklabs.net>
From: Steven Noonan <snoonan@amazon.com>
This is caused by a linux/xattr.h and sys/xattr.h incompatibility:
In file included from /home/snoonan/Development/qemu/include/qemu/xattr.h:27:0,
from fsdev/virtfs-proxy-helper.c:25:
/usr/include/sys/xattr.h:31:3: error: expected identifier before numeric constant
XATTR_CREATE = 1, /* set value, fail if attr already exists. */
^
/home/snoonan/Development/qemu/qemu/rules.mak:25: recipe for target 'fsdev/virtfs-proxy-helper.o' failed
Moving the include around resolves it.
Signed-off-by: Steven Noonan <snoonan@amazon.com>
Cc: Anthony Liguori <aliguori@amazon.com>
---
fsdev/virtfs-proxy-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index 713a7b2..c10a085 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -12,7 +12,6 @@
#include <sys/resource.h>
#include <getopt.h>
#include <syslog.h>
-#include <sys/capability.h>
#include <sys/fsuid.h>
#include <sys/vfs.h>
#include <sys/ioctl.h>
@@ -23,6 +22,7 @@
#include "qemu-common.h"
#include "qemu/sockets.h"
#include "qemu/xattr.h"
+#include <sys/capability.h>
#include "virtio-9p-marshal.h"
#include "hw/9pfs/virtio-9p-proxy.h"
#include "fsdev/virtio-9p-marshal.h"
--
1.8.5.2
next prev parent reply other threads:[~2014-01-09 21:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:55 [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Steven Noonan
2014-01-09 21:55 ` Steven Noonan [this message]
2014-01-09 21:55 ` [Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS Steven Noonan
2014-01-09 23:27 ` Peter Maydell
2014-01-09 23:30 ` Noonan, Steven
2014-01-10 9:12 ` Markus Armbruster
2014-01-09 22:30 ` [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Peter Maydell
2014-01-09 22:40 ` Paolo Bonzini
2014-01-09 23:18 ` Brad Smith
2014-01-09 23:31 ` Noonan, Steven
2014-01-11 2:36 ` Noonan, Steven
2014-01-11 7:46 ` Stefan Weil
2014-01-13 11:53 ` Paolo Bonzini
2014-01-13 20:00 ` [Qemu-devel] [PATCH] " Steven Noonan
2014-01-13 20:27 ` Stefan Weil
2014-01-13 20:38 ` Noonan, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389304508-10100-2-git-send-email-steven@uplinklabs.net \
--to=steven@uplinklabs.net \
--cc=aliguori@amazon.com \
--cc=qemu-devel@nongnu.org \
--cc=snoonan@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).