From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2cBU-0007BA-P9 for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2cBN-00054K-FI for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:43:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2cBN-00054D-7c for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:43:37 -0500 From: Stefan Hajnoczi Date: Mon, 13 Jan 2014 15:43:16 +0800 Message-Id: <1389598998-19897-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1389598998-19897-1-git-send-email-stefanha@redhat.com> References: <1389598998-19897-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 1/3] net: Use g_strdup_printf instead of snprintf. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori From: Hani Benhabiles assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles Signed-off-by: Stefan Hajnoczi --- net/net.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index f8db85f..2c3af20 100644 --- a/net/net.c +++ b/net/net.c @@ -164,7 +164,6 @@ void qemu_macaddr_default_if_unset(MACAddr *macaddr) static char *assign_name(NetClientState *nc1, const char *model) { NetClientState *nc; - char buf[256]; int id = 0; QTAILQ_FOREACH(nc, &net_clients, next) { @@ -176,9 +175,7 @@ static char *assign_name(NetClientState *nc1, const char *model) } } - snprintf(buf, sizeof(buf), "%s.%d", model, id); - - return g_strdup(buf); + return g_strdup_printf("%s.%d", model, id); } static void qemu_net_client_destructor(NetClientState *nc) -- 1.8.4.2