From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2uh1-0007zU-Io for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2ugv-0007xZ-Ji for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:29:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2ugv-0007xS-Be for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:29:25 -0500 From: Stefan Hajnoczi Date: Mon, 13 Jan 2014 18:47:39 +0800 Message-Id: <1389610059-27806-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] dataplane: fix shadowed return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Peter Maydell Propagate the error return value from get_indirect(). Signed-off-by: Stefan Hajnoczi --- hw/virtio/dataplane/vring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 250d45e..665a1ff 100644 --- a/hw/virtio/dataplane/vring.c +++ b/hw/virtio/dataplane/vring.c @@ -376,7 +376,7 @@ int vring_pop(VirtIODevice *vdev, Vring *vring, barrier(); if (desc.flags & VRING_DESC_F_INDIRECT) { - int ret = get_indirect(vring, elem, &desc); + ret = get_indirect(vring, elem, &desc); if (ret < 0) { goto out; } -- 1.8.4.2