From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lVj-00025d-2n for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2lVd-0006c6-3K for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lVc-0006bx-QI for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:09 -0500 From: Juan Quintela Date: Mon, 13 Jan 2014 18:40:06 +0100 Message-Id: <1389634834-24181-22-git-send-email-quintela@redhat.com> In-Reply-To: <1389634834-24181-1-git-send-email-quintela@redhat.com> References: <1389634834-24181-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 21/49] memory: set single dirty flags when possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: anthony@codemonkey.ws Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 7 ++++--- include/exec/memory-internal.h | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index a8c79e5..ffda8be 100644 --- a/exec.c +++ b/exec.c @@ -1912,7 +1912,8 @@ static void invalidate_and_set_dirty(hwaddr addr, /* invalidate code */ tb_invalidate_phys_page_range(addr, addr + length, 0); /* set dirty bit */ - cpu_physical_memory_set_dirty_flags(addr, (0xff & ~CODE_DIRTY_FLAG)); + cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG); + cpu_physical_memory_set_dirty_flag(addr, MIGRATION_DIRTY_FLAG); } xen_modified_memory(addr, length); } @@ -2527,8 +2528,8 @@ void stl_phys_notdirty(hwaddr addr, uint32_t val) /* invalidate code */ tb_invalidate_phys_page_range(addr1, addr1 + 4, 0); /* set dirty bit */ - cpu_physical_memory_set_dirty_flags( - addr1, (0xff & ~CODE_DIRTY_FLAG)); + cpu_physical_memory_set_dirty_flag(addr1, MIGRATION_DIRTY_FLAG); + cpu_physical_memory_set_dirty_flag(addr1, VGA_DIRTY_FLAG); } } } diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 53cfe83..9f4ad69 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -89,7 +89,9 @@ static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr, static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) { - cpu_physical_memory_set_dirty_flags(addr, 0xff); + cpu_physical_memory_set_dirty_flag(addr, MIGRATION_DIRTY_FLAG); + cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG); + cpu_physical_memory_set_dirty_flag(addr, CODE_DIRTY_FLAG); } static inline int cpu_physical_memory_clear_dirty_flags(ram_addr_t addr, -- 1.8.4.2