From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lVM-0001NT-EA for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:40:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2lVG-0006Vk-BY for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:40:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lVG-0006VW-3Q for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:40:46 -0500 From: Juan Quintela Date: Mon, 13 Jan 2014 18:39:48 +0100 Message-Id: <1389634834-24181-4-git-send-email-quintela@redhat.com> In-Reply-To: <1389634834-24181-1-git-send-email-quintela@redhat.com> References: <1389634834-24181-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 03/49] migration: Fix rate limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Matthew Garrett , anthony@codemonkey.ws From: Matthew Garrett The migration thread appears to want to allow writeout to occur at full speed rather than being rate limited during completion of state saving, but sets the limit to INT_MAX when xfer_limit is INT64_MAX. This causes problems if there's more than 2GB of state left to save at this point. It probably ought to just be INT64_MAX instead. Signed-off-by: Matthew Garrett Reviewed-by: Paolo Bonzini Signed-off-by: Juan Quintela --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 4ee341b..e5f6b98 100644 --- a/migration.c +++ b/migration.c @@ -596,7 +596,7 @@ static void *migration_thread(void *opaque) ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE); if (ret >= 0) { - qemu_file_set_rate_limit(s->file, INT_MAX); + qemu_file_set_rate_limit(s->file, INT64_MAX); qemu_savevm_state_complete(s->file); } qemu_mutex_unlock_iothread(); -- 1.8.4.2