From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lWA-0002xQ-GD for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2lW4-00074i-Fb for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2lW4-00074X-7F for qemu-devel@nongnu.org; Mon, 13 Jan 2014 12:41:36 -0500 From: Juan Quintela Date: Mon, 13 Jan 2014 18:40:26 +0100 Message-Id: <1389634834-24181-42-git-send-email-quintela@redhat.com> In-Reply-To: <1389634834-24181-1-git-send-email-quintela@redhat.com> References: <1389634834-24181-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: anthony@codemonkey.ws Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake Reviewed-by: Orit Wasserman --- exec.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index c71f2d5..514d6a0 100644 --- a/exec.c +++ b/exec.c @@ -57,7 +57,7 @@ //#define DEBUG_SUBPAGE #if !defined(CONFIG_USER_ONLY) -static int in_migration; +static bool in_migration; RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) }; @@ -752,11 +752,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t length, } } -static int cpu_physical_memory_set_dirty_tracking(int enable) +static void cpu_physical_memory_set_dirty_tracking(bool enable) { - int ret = 0; in_migration = enable; - return ret; } hwaddr memory_region_section_get_iotlb(CPUArchState *env, @@ -1798,12 +1796,12 @@ static void tcg_commit(MemoryListener *listener) static void core_log_global_start(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(1); + cpu_physical_memory_set_dirty_tracking(true); } static void core_log_global_stop(MemoryListener *listener) { - cpu_physical_memory_set_dirty_tracking(0); + cpu_physical_memory_set_dirty_tracking(false); } static MemoryListener core_memory_listener = { -- 1.8.4.2