qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vincenzo Maffione <v.maffione@gmail.com>
To: qemu-devel@nongnu.org
Cc: aliguori@amazon.com, marcel.a@redhat.com, jasowang@redhat.com,
	Vincenzo Maffione <v.maffione@gmail.com>,
	lcapitulino@redhat.com, stefanha@redhat.com, dmitry@daynix.com,
	pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it
Subject: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support
Date: Tue, 14 Jan 2014 11:59:44 +0100	[thread overview]
Message-ID: <1389697190-6198-1-git-send-email-v.maffione@gmail.com> (raw)

The purpose of this patch series is to add offloadings support
(TSO/UFO/CSUM) to the netmap network backend, and make it possible
for the paravirtual network frontends (virtio-net and vmxnet3) to
use it.
In order to achieve this, these patches extend the existing
net.h interface to add abstract operations through which a network
frontend can manipulate backend offloading features, instead of
directly calling TAP-specific functions.

Guest-to-guest performance before this patches for virtio-net + netmap:

    TCP_STREAM                  5.0 Gbps
    TCP_RR                      12.7 Gbps
    UDP_STREAM (64-bytes)       790 Kpps

Guest-to-guest performance after this patches for virtio-net + netmap:

    TCP_STREAM                  21.4 Gbps
    TCP_RR                      12.7 Gbps
    UDP_STREAM (64-bytes)       790 Kpps

Experiment details:
    - Processor: Intel i7-3770K CPU @ 3.50GHz (8 cores)
    - Memory @ 1333 MHz
    - Host O.S.: Archlinux with Linux 3.11
    - Guest O.S.: Archlinux with Linux 3.11

    - QEMU command line:
        qemu-system-x86_64 archdisk.qcow -snapshot -enable-kvm -device virtio-net-pci,ioeventfd=on,mac=00:AA:BB:CC:DD:01,netdev=mynet -netdev netmap,ifname=vale0:01,id=mynet -smp 2 -vga std -m 3G


******** Changes against the previous version ***********
(1) The first two commits were not included into the previous version. They
    are used to clean the TAP interface before the offloadings manipulation
    API is introduced.

(2) The fifth commit merges two commits from the previous version: 3/5 "virtio-net and
    vmxnet3 use offloading API" and 5/5 "virtio-net and vmxnet3 can use netmap offloadings".
    This because of (3).

(3) There is actually an important problem. In the previous patch version, TCP/UDP traffic was
    supported between two guests attached to a VALE switch if and only if both guests use (or
    don't) the same offloadings: e.g. two virtio-net guests or two e1000 guests. This is why
    in this version I put the commit which adds the support for netmap as the last one and
    I temporarily disable the offloading feature (e.g. netmap_has_vnet_hdr() returns false).
    We are working at adding proper support also in the general case in which there is
    a mismatch between the NIC offloadings capabilities. As soon as we have proper support,
    we can enable it in net/netmap.c.
    What do you think about that? What's the best way to manage this temporary lack of
    support?


Vincenzo Maffione (6):
  net: change vnet-hdr TAP prototypes
  net: removing tap_using_vnet_hdr() function
  net: extend NetClientInfo for offloading manipulations
  net: TAP uses NetClientInfo offloading callbacks
  net: virtio-net and vmxnet3 use offloading API
  net: add offloadings support to netmap backend

 hw/net/virtio-net.c | 18 +++++-----------
 hw/net/vmxnet3.c    | 12 ++++-------
 include/net/net.h   | 17 +++++++++++++++
 include/net/tap.h   |  5 ++---
 net/net.c           | 46 +++++++++++++++++++++++++++++++++++++++++
 net/netmap.c        | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 net/tap-win32.c     | 12 ++++-------
 net/tap.c           | 22 ++++++++------------
 8 files changed, 145 insertions(+), 46 deletions(-)

-- 
1.8.5.2

             reply	other threads:[~2014-01-14 11:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 10:59 Vincenzo Maffione [this message]
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 1/6] net: change vnet-hdr TAP prototypes Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function Vincenzo Maffione
2014-01-16  8:39   ` Stefan Hajnoczi
2014-01-16  9:29   ` Michael S. Tsirkin
2014-01-17  3:29     ` Stefan Hajnoczi
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 3/6] net: extend NetClientInfo for offloading manipulations Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 4/6] net: TAP uses NetClientInfo offloading callbacks Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 5/6] net: virtio-net and vmxnet3 use offloading API Vincenzo Maffione
2014-01-14 10:59 ` [Qemu-devel] [PATCH v2 6/6] net: add offloadings support to netmap backend Vincenzo Maffione
2014-01-15  6:49 ` [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support Barak Wasserstrom
2014-01-16  9:08 ` Stefan Hajnoczi
2014-01-16 15:00   ` Vincenzo Maffione
2014-01-17  3:28     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1389697190-6198-1-git-send-email-v.maffione@gmail.com \
    --to=v.maffione@gmail.com \
    --cc=aliguori@amazon.com \
    --cc=dmitry@daynix.com \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jasowang@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rizzo@iet.unipi.it \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).