From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W39Ti-0005ts-IK for qemu-devel@nongnu.org; Tue, 14 Jan 2014 14:16:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W39TU-0000y3-Eo for qemu-devel@nongnu.org; Tue, 14 Jan 2014 14:16:46 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:48679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W39TU-0000xg-82 for qemu-devel@nongnu.org; Tue, 14 Jan 2014 14:16:32 -0500 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Jan 2014 12:16:31 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 4E58A19D803E for ; Tue, 14 Jan 2014 12:16:20 -0700 (MST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08025.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0EJGTpE6488438 for ; Tue, 14 Jan 2014 20:16:29 +0100 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0EJGStH013443 for ; Tue, 14 Jan 2014 12:16:28 -0700 From: Eric Farman Date: Tue, 14 Jan 2014 14:16:25 -0500 Message-Id: <1389726986-8600-3-git-send-email-farman@linux.vnet.ibm.com> In-Reply-To: <1389726986-8600-1-git-send-email-farman@linux.vnet.ibm.com> References: <1389726986-8600-1-git-send-email-farman@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v2 2/3] scsi/virtio-scsi: Cleanup of I/Os that never started List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini There is still a small window that occurs when a cancel I/O affects an asynchronous I/O operation that hasn't started. In other words, when the residual data length equals the expected data length. Today, the routine virtio_scsi_command_complete fails because the VirtIOSCSIReq pointer (from the hba_private field in SCSIRequest) was cleared earlier when virtio_scsi_complete_req was called by the virtio_scsi_request_cancelled routine. As a result, the virtio_scsi_command_complete routine needs to simply return when it is processing a SCSIRequest block that was marked canceled. Reviewed-by: Paolo Bonzini Signed-off-by: Eric Farman --- hw/scsi/virtio-scsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6dcdd1b..1da98cd 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -306,6 +306,10 @@ static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status, VirtIOSCSIReq *req = r->hba_private; uint32_t sense_len; + if (r->io_canceled) { + return; + } + req->resp.cmd->response = VIRTIO_SCSI_S_OK; req->resp.cmd->status = status; if (req->resp.cmd->status == GOOD) { -- 1.7.9.5