From: Gal Hammer <ghammer@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>, Gal Hammer <ghammer@redhat.com>
Subject: [Qemu-devel] [PATCH] char: udp chardev shouldn't require an explicit open.
Date: Thu, 16 Jan 2014 14:59:33 +0200 [thread overview]
Message-ID: <1389877173-13673-1-git-send-email-ghammer@redhat.com> (raw)
A chardev with a UDP backend never send the CHR_EVENT_OPENED
event. This cause the virtio-serial port not to work because
data is dropped when no listner on the host side.
Signed-off-by: Gal Hammer <ghammer@redhat.com>
---
qemu-char.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 30c5a6a..7d138ee 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2263,8 +2263,6 @@ static CharDriverState *qemu_chr_open_udp_fd(int fd)
chr->chr_write = udp_chr_write;
chr->chr_update_read_handler = udp_chr_update_read_handler;
chr->chr_close = udp_chr_close;
- /* be isn't opened until we get a connection */
- chr->explicit_be_open = true;
return chr;
}
--
1.8.4.2
reply other threads:[~2014-01-16 12:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389877173-13673-1-git-send-email-ghammer@redhat.com \
--to=ghammer@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).