From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3mXz-0001P8-40 for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:59:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3mXt-0004ra-5B for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:59:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3mXs-0004rQ-TS for qemu-devel@nongnu.org; Thu, 16 Jan 2014 07:59:41 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GCxd4M027828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 Jan 2014 07:59:40 -0500 From: Gal Hammer Date: Thu, 16 Jan 2014 14:59:33 +0200 Message-Id: <1389877173-13673-1-git-send-email-ghammer@redhat.com> Subject: [Qemu-devel] [PATCH] char: udp chardev shouldn't require an explicit open. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Gal Hammer A chardev with a UDP backend never send the CHR_EVENT_OPENED event. This cause the virtio-serial port not to work because data is dropped when no listner on the host side. Signed-off-by: Gal Hammer --- qemu-char.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 30c5a6a..7d138ee 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2263,8 +2263,6 @@ static CharDriverState *qemu_chr_open_udp_fd(int fd) chr->chr_write = udp_chr_write; chr->chr_update_read_handler = udp_chr_update_read_handler; chr->chr_close = udp_chr_close; - /* be isn't opened until we get a connection */ - chr->explicit_be_open = true; return chr; } -- 1.8.4.2