From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oBv-000317-P0 for qemu-devel@nongnu.org; Thu, 16 Jan 2014 09:45:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3oBp-0000Ww-RQ for qemu-devel@nongnu.org; Thu, 16 Jan 2014 09:45:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3oBp-0000UJ-Jf for qemu-devel@nongnu.org; Thu, 16 Jan 2014 09:45:01 -0500 Message-ID: <1389883491.10990.31.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 16 Jan 2014 15:44:51 +0100 In-Reply-To: <1389874718-6785-2-git-send-email-mmishael@redhat.com> References: <1389874718-6785-1-git-send-email-mmishael@redhat.com> <1389874718-6785-2-git-send-email-mmishael@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miki Mishael Cc: Michael Roth , "Michael S. Tsirkin" , Yan Vugenfirer , qemu-devel@nongnu.org, Adam Litke , Ronen Hod , Anthony Liguori , Paolo Bonzini , Dmitry Fleytman On Do, 2014-01-16 at 07:18 -0500, Miki Mishael wrote: > Support for pci-serial-2x and pci-serial-4x > added to inf file. > Standard Windows driver mf.sys used to > split single function > device into per-port nodes. Patch looks good. Not that I understand everything of it (the original .inf file was largely a copy + try to adapt job), but the parts I'm able to parse are sane. Reviewed-by: Gerd Hoffmann cheers, Gerd