From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Kce-0006CZ-Pp for qemu-devel@nongnu.org; Mon, 20 Jan 2014 14:35:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5KcX-0005cF-1b for qemu-devel@nongnu.org; Mon, 20 Jan 2014 14:35:00 -0500 Received: from ssl.serverraum.org ([88.198.40.39]:57896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5KcW-0005bw-S6 for qemu-devel@nongnu.org; Mon, 20 Jan 2014 14:34:52 -0500 From: Michael Walle Date: Mon, 20 Jan 2014 20:34:23 +0100 Message-Id: <1390246471-25167-6-git-send-email-michael@walle.cc> In-Reply-To: <1390246471-25167-1-git-send-email-michael@walle.cc> References: <1390246471-25167-1-git-send-email-michael@walle.cc> Subject: [Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Michael Walle , Anthony Liguori In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian host. Cc: Paolo Bonzini Signed-off-by: Michael Walle --- hw/display/milkymist-vgafb_template.h | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/milkymist-vgafb_template.h b/hw/display/milkymist-vgafb_template.h index e0036e1..3f25484 100644 --- a/hw/display/milkymist-vgafb_template.h +++ b/hw/display/milkymist-vgafb_template.h @@ -62,6 +62,7 @@ static void glue(draw_line_, BITS)(void *opaque, uint8_t *d, const uint8_t *s, while (width--) { memcpy(&rgb565, s, sizeof(rgb565)); + rgb565 = be16_to_cpu(rgb565); r = ((rgb565 >> 11) & 0x1f) << 3; g = ((rgb565 >> 5) & 0x3f) << 2; b = ((rgb565 >> 0) & 0x1f) << 3; -- 1.7.10.4