From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison
Date: Tue, 21 Jan 2014 11:55:35 +0100 [thread overview]
Message-ID: <1390301735.4026.0.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1390237032-27159-1-git-send-email-alevy@redhat.com>
On Mo, 2014-01-20 at 18:57 +0200, Alon Levy wrote:
> Several small signedness / overflow corrections to
> qxl_create_guest_primary:
> 1. use 64 bit unsigned for size to avoid overflow possible from two 32
> bit multiplicants.
> 2. correct sign for requested_height
> 3. add a more verbose error message when setting guest bug state
> (which
> causes a complete guess blackout until reset, so it helps if it is
> verbose).
Added to spice patch queue.
thanks,
Gerd
prev parent reply other threads:[~2014-01-21 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 16:57 [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison Alon Levy
2014-01-21 10:55 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390301735.4026.0.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).