From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Yzj-000057-F3 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:55:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5Yzd-0000Ar-GX for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:55:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5Yzd-0000An-86 for qemu-devel@nongnu.org; Tue, 21 Jan 2014 05:55:41 -0500 Message-ID: <1390301735.4026.0.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 21 Jan 2014 11:55:35 +0100 In-Reply-To: <1390237032-27159-1-git-send-email-alevy@redhat.com> References: <1390237032-27159-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com On Mo, 2014-01-20 at 18:57 +0200, Alon Levy wrote: > Several small signedness / overflow corrections to > qxl_create_guest_primary: > 1. use 64 bit unsigned for size to avoid overflow possible from two 32 > bit multiplicants. > 2. correct sign for requested_height > 3. add a more verbose error message when setting guest bug state > (which > causes a complete guess blackout until reset, so it helps if it is > verbose). Added to spice patch queue. thanks, Gerd