qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 1/4] spapr: support only ELF kernel images
Date: Wed, 22 Jan 2014 16:20:38 +1100	[thread overview]
Message-ID: <1390368041-2184-2-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1390368041-2184-1-git-send-email-aik@ozlabs.ru>

Currently everybody uses ELF kernel images with "-kernel" option on
pseries machine but QEMU still tries to boot from an image even it
fails to recognize it is ELF. This produces undefined behaviour if
the user tries a kernel image compiled for another architecture.

This removes support of raw kernel images.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/ppc/spapr.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 5b21562..851ce4b 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1313,11 +1313,6 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
             kernel_le = kernel_size > 0;
         }
         if (kernel_size < 0) {
-            kernel_size = load_image_targphys(kernel_filename,
-                                              KERNEL_LOAD_ADDR,
-                                              load_limit - KERNEL_LOAD_ADDR);
-        }
-        if (kernel_size < 0) {
             fprintf(stderr, "qemu: could not load kernel '%s'\n",
                     kernel_filename);
             exit(1);
-- 
1.8.4.rc4

  reply	other threads:[~2014-01-22  5:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22  5:20 [Qemu-devel] [PATCH 0/4 v2] elf loader: exit if incompatible architecture is detected Alexey Kardashevskiy
2014-01-22  5:20 ` Alexey Kardashevskiy [this message]
2014-01-22  5:20 ` [Qemu-devel] [PATCH 2/4] moxie: fix load_elf() usage Alexey Kardashevskiy
2014-01-31  7:18   ` Alexander Graf
2014-01-22  5:20 ` [Qemu-devel] [PATCH 3/4] elf-loader: add more return codes Alexey Kardashevskiy
2014-01-22  7:27   ` Alexey Kardashevskiy
2014-01-31  2:15     ` Alexey Kardashevskiy
2014-01-22  5:20 ` [Qemu-devel] [PATCH 4/4] spapr: add more details error description of why load_elf() failed Alexey Kardashevskiy
2014-01-31  7:20   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390368041-2184-2-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=agraf@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).