From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com,
aliguori@amazon.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema
Date: Thu, 23 Jan 2014 15:30:16 +0800 [thread overview]
Message-ID: <1390462216-23273-1-git-send-email-akong@redhat.com> (raw)
After cleaning up the comments of qapi-schema.json file, we get
an range of raw expressions, they are also converted to ordered
dictionaries.
This patch just addes a member to QAPISchema to store the raw
expressions.
Actually this patch was split from QMP introspection patchset,
it's no longer needed in that patchset. I would like to post
this patch singly, we can apply it if it's useful.
Signed-off-by: Amos Kong <akong@redhat.com>
---
scripts/qapi.py | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 750e9fb..7b92689 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -61,10 +61,13 @@ class QAPISchema:
self.src += '\n'
self.cursor = 0
self.exprs = []
+ self.raw_exprs = []
self.accept()
while self.tok != None:
- self.exprs.append(self.get_expr(False))
+ self.cur_entry= ''
+ self.exprs.append(self.get_expr(False, True))
+ self.raw_exprs.append(self.cur_entry)
def accept(self):
while True:
@@ -103,9 +106,11 @@ class QAPISchema:
elif not self.tok.isspace():
raise QAPISchemaError(self, 'Stray "%s"' % self.tok)
- def get_members(self):
+ def get_members(self, start=None):
expr = OrderedDict()
if self.tok == '}':
+ if start != None:
+ self.cur_entry = self.src[start:self.cursor]
self.accept()
return expr
if self.tok != "'":
@@ -118,6 +123,8 @@ class QAPISchema:
self.accept()
expr[key] = self.get_expr(True)
if self.tok == '}':
+ if start != None:
+ self.cur_entry = self.src[start:self.cursor]
self.accept()
return expr
if self.tok != ',':
@@ -142,12 +149,15 @@ class QAPISchema:
raise QAPISchemaError(self, 'Expected "," or "]"')
self.accept()
- def get_expr(self, nested):
+ def get_expr(self, nested, first=False):
if self.tok != '{' and not nested:
raise QAPISchemaError(self, 'Expected "{"')
if self.tok == '{':
+ start = None
+ if first:
+ start = self.cursor - 1
self.accept()
- expr = self.get_members()
+ expr = self.get_members(start)
elif self.tok == '[':
self.accept()
expr = self.get_values()
--
1.8.4.2
next reply other threads:[~2014-01-23 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 7:30 Amos Kong [this message]
2014-01-23 10:53 ` [Qemu-devel] [PATCH] qapi: store raw expressions to QAPISchema Markus Armbruster
2014-01-23 11:53 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390462216-23273-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).