From: Amos Kong <akong@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH] qapi: cleanup redundant variable
Date: Thu, 23 Jan 2014 16:54:37 +0800 [thread overview]
Message-ID: <1390467277-16499-1-git-send-email-akong@redhat.com> (raw)
No need to re-append an expr list, it's ok to return schema.exprs
Signed-off-by: Amos Kong <akong@redhat.com>
---
scripts/qapi.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 7b92689..718f1ad 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -175,8 +175,6 @@ def parse_schema(fp):
print >>sys.stderr, e
exit(1)
- exprs = []
-
for expr in schema.exprs:
if expr.has_key('enum'):
add_enum(expr['enum'])
@@ -185,9 +183,8 @@ def parse_schema(fp):
add_enum('%sKind' % expr['union'])
elif expr.has_key('type'):
add_struct(expr)
- exprs.append(expr)
- return exprs
+ return schema.exprs
def parse_args(typeinfo):
if isinstance(typeinfo, basestring):
--
1.8.4.2
next reply other threads:[~2014-01-23 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 8:54 Amos Kong [this message]
2014-02-01 9:49 ` [Qemu-devel] [Qemu-trivial] [PATCH] qapi: cleanup redundant variable Michael Tokarev
2014-02-03 18:23 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390467277-16499-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).