From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6IrS-0000X9-KT for qemu-devel@nongnu.org; Thu, 23 Jan 2014 06:54:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6IrJ-0006Ww-Hn for qemu-devel@nongnu.org; Thu, 23 Jan 2014 06:54:18 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 23 Jan 2014 12:53:54 +0100 Message-Id: <1390478036-5507-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1390478036-5507-1-git-send-email-pbonzini@redhat.com> References: <1390478036-5507-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 3/5] virtio-scsi: Prevent assertion on missed events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eric Farman , qemu-stable@nongnu.org From: Eric Farman In some cases, an unplug can cause events to be dropped, which leads to an assertion failure when preparing to notify the guest kernel. Signed-off-by: Eric Farman Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 1da98cd..6610b3a 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -520,7 +520,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, SCSIDevice *dev, evt->event = event; evt->reason = reason; if (!dev) { - assert(event == VIRTIO_SCSI_T_NO_EVENT); + assert(event == VIRTIO_SCSI_T_EVENTS_MISSED); } else { evt->lun[0] = 1; evt->lun[1] = dev->id; -- 1.8.3.1