qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit.canet@irqsave.net>,
	famz@redhat.com, "Benoit Canet" <benoit@irqsave.net>,
	armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().
Date: Thu, 23 Jan 2014 21:31:39 +0100	[thread overview]
Message-ID: <1390509099-695-9-git-send-email-benoit.canet@irqsave.net> (raw)
In-Reply-To: <1390509099-695-1-git-send-email-benoit.canet@irqsave.net>

Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block.c b/block.c
index 3e0994b..7726636 100644
--- a/block.c
+++ b/block.c
@@ -908,15 +908,15 @@ int bdrv_file_open(BlockDriverState **pbs, const char *filename,
 
     if (reference) {
         if (filename || qdict_size(options)) {
-            error_setg(errp, "Cannot reference an existing block device with "
+            error_setg(errp, "Cannot reference an existing graph node with "
                        "additional options or a new filename");
             return -EINVAL;
         }
         QDECREF(options);
 
-        bs = bdrv_find(reference);
+        bs = bdrv_find_node(reference);
         if (!bs) {
-            error_setg(errp, "Cannot find block device '%s'", reference);
+            error_setg(errp, "Cannot find graph node '%s'", reference);
             return -ENODEV;
         }
         bdrv_ref(bs);
-- 
1.8.3.2

  parent reply	other threads:[~2014-01-23 20:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 20:31 [Qemu-devel] [PATCH V6 0/8] Giving names to graph's BlockDriverState Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 1/8] block: Add bs->node_name to hold the name of a bs node of the bs graph Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 2/8] block: Allow the user to define "node-name" option both on command line and QMP Benoît Canet
2014-01-24 14:51   ` Benoît Canet
2014-01-24 15:10     ` Kevin Wolf
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 3/8] qmp: Add QMP query-named-block-nodes to list the named BlockDriverState nodes Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 4/8] qmp: Allow to change password on named block driver states Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 5/8] block: Create authorizations mechanism for external snapshot and resize Benoît Canet
2014-02-04  0:15   ` Jeff Cody
2014-02-04 10:25     ` Kevin Wolf
2014-02-04 13:03       ` Jeff Cody
2014-02-10 19:39       ` Benoît Canet
2014-02-10 19:45       ` Benoît Canet
2014-02-10 20:18       ` Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 6/8] qmp: Allow block_resize to manipulate bs graph nodes Benoît Canet
2014-01-23 20:31 ` [Qemu-devel] [PATCH V6 7/8] qmp: Allow to take external snapshots on bs graphs node Benoît Canet
2014-01-23 20:31 ` Benoît Canet [this message]
2014-01-24 13:26   ` [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open() Kevin Wolf
2014-01-24 13:37     ` Max Reitz
2014-01-24 14:48       ` Kevin Wolf
2014-01-24 14:54         ` Max Reitz
2014-01-27 14:36           ` Benoît Canet
2014-01-27 19:11             ` Max Reitz
2014-01-28  0:04               ` Benoît Canet
2014-01-31 20:32                 ` Max Reitz
2014-01-31 21:37                   ` Benoît Canet
2014-02-03  9:43                     ` Kevin Wolf
2014-02-04 13:02                       ` Eric Blake
2014-01-24 13:27 ` [Qemu-devel] [PATCH V6 0/8] Giving names to graph's BlockDriverState Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390509099-695-9-git-send-email-benoit.canet@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=armbru@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).