From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6kVT-0004I8-21 for qemu-devel@nongnu.org; Fri, 24 Jan 2014 12:25:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6kVM-0008PM-Si for qemu-devel@nongnu.org; Fri, 24 Jan 2014 12:25:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6kVM-0008PG-Ld for qemu-devel@nongnu.org; Fri, 24 Jan 2014 12:25:20 -0500 From: Kevin Wolf Date: Fri, 24 Jan 2014 18:21:52 +0100 Message-Id: <1390584136-24703-70-git-send-email-kwolf@redhat.com> In-Reply-To: <1390584136-24703-1-git-send-email-kwolf@redhat.com> References: <1390584136-24703-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 69/93] block: Detect unaligned length in bdrv_qiov_is_aligned() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org For an O_DIRECT request to succeed, it's not only necessary that all base addresses in the qiov are aligned, but also that each length in it is aligned. Signed-off-by: Kevin Wolf Reviewed-by: Wenchao Xia Reviewed-by: Max Reitz --- block.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block.c b/block.c index 9d0cfc4..275d387 100644 --- a/block.c +++ b/block.c @@ -4811,6 +4811,9 @@ bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov) if ((uintptr_t) qiov->iov[i].iov_base % bs->buffer_alignment) { return false; } + if (qiov->iov[i].iov_len % bs->buffer_alignment) { + return false; + } } return true; -- 1.8.1.4