From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pEW-0006qg-0H for qemu-devel@nongnu.org; Fri, 24 Jan 2014 17:28:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6pEN-0000Lg-FS for qemu-devel@nongnu.org; Fri, 24 Jan 2014 17:28:15 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:39780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6pEN-0000LD-7u for qemu-devel@nongnu.org; Fri, 24 Jan 2014 17:28:07 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so1235512eaj.21 for ; Fri, 24 Jan 2014 14:28:04 -0800 (PST) From: Hani Benhabiles Date: Fri, 24 Jan 2014 23:27:55 +0100 Message-Id: <1390602475-19621-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH] monitor: Add device_add type argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com Signed-off-by: Hani Benhabiles --- monitor.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/monitor.c b/monitor.c index 845f608..cf91544 100644 --- a/monitor.c +++ b/monitor.c @@ -4254,6 +4254,26 @@ static const char *next_arg_type(const char *typestr) return (p != NULL ? ++p : typestr); } +static void device_add_completion(ReadLineState *rs, const char *str) +{ + GSList *list, *elt; + size_t len; + len = strlen(str); + readline_set_completion_index(rs, len); + list = elt = object_class_get_list(TYPE_DEVICE, false); + while (elt) { + const char *name; + DeviceClass *dc = OBJECT_CLASS_CHECK(DeviceClass, elt->data, + TYPE_DEVICE); + name = object_class_get_name(OBJECT_CLASS(dc)); + if (!strncmp(name, str, len)) { + readline_add_completion(rs, name); + } + elt = elt->next; + } + g_slist_free(list); +} + static void monitor_find_completion_by_table(Monitor *mon, const mon_cmd_t *cmd_table, char **args, @@ -4317,6 +4337,11 @@ static void monitor_find_completion_by_table(Monitor *mon, readline_set_completion_index(mon->rs, strlen(str)); bdrv_iterate(block_completion_it, &mbs); break; + case 'O': + if (!strcmp(cmd->name, "device_add")) { + device_add_completion(mon->rs, str); + } + break; case 's': case 'S': if (!strcmp(cmd->name, "sendkey")) { -- 1.8.3.2