qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com,
	imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v12 11/11] block: Allow backup on referenced named BlockDriverState
Date: Mon, 27 Jan 2014 11:48:17 +0800	[thread overview]
Message-ID: <1390794497-26281-12-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1390794497-26281-1-git-send-email-famz@redhat.com>

Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and any other operation on it will be blocked by that.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block.c b/block.c
index e51ead3..1e50f1e 100644
--- a/block.c
+++ b/block.c
@@ -1102,6 +1102,8 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd)
     /* Otherwise we won't be able to commit due to check in bdrv_commit */
     bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_COMMIT,
                     bs->backing_blocker);
+    bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE,
+                    bs->backing_blocker);
     pstrcpy(bs->backing_file, sizeof(bs->backing_file),
             bs->backing_hd->file->filename);
     pstrcpy(bs->backing_format, sizeof(bs->backing_format),
-- 
1.8.5.3

  parent reply	other threads:[~2014-01-27  3:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27  3:48 [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 01/11] block: Add BlockOpType enum Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 02/11] block: Introduce op_blockers to BlockDriverState Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 03/11] block: Replace in_use with operation blocker Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 04/11] block: Move op_blocker check from block_job_create to its caller Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 05/11] block: Add bdrv_set_backing_hd() Fam Zheng
2014-01-28 17:09   ` Stefan Hajnoczi
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 06/11] block: Add backing_blocker in BlockDriverState Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 07/11] block: Parse "backing" option to reference existing BDS Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 08/11] block: Support dropping active in bdrv_drop_intermediate Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 09/11] stream: Use bdrv_drop_intermediate and drop close_unused_images Fam Zheng
2014-01-27  3:48 ` [Qemu-devel] [PATCH v12 10/11] qmp: Add command 'blockdev-backup' Fam Zheng
2014-01-27  3:48 ` Fam Zheng [this message]
2014-01-28 14:31 ` [Qemu-devel] [PATCH v12 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Stefan Hajnoczi
2014-01-28 16:57   ` Ian Main
2014-01-29  8:44     ` Stefan Hajnoczi
2014-01-29 10:23       ` Kevin Wolf
2014-01-29  4:35   ` Fam Zheng
2014-01-28 17:22 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390794497-26281-12-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imain@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).