From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8NO0-0008LH-3l for qemu-devel@nongnu.org; Wed, 29 Jan 2014 00:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8NNu-0008Bt-4h for qemu-devel@nongnu.org; Wed, 29 Jan 2014 00:08:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8NNt-0008BZ-Rh for qemu-devel@nongnu.org; Wed, 29 Jan 2014 00:08:22 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0T58Kjt030266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jan 2014 00:08:20 -0500 From: Fam Zheng Date: Wed, 29 Jan 2014 13:07:36 +0800 Message-Id: <1390972061-26560-10-git-send-email-famz@redhat.com> In-Reply-To: <1390972061-26560-1-git-send-email-famz@redhat.com> References: <1390972061-26560-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v13 09/14] stream: Use bdrv_drop_intermediate and drop close_unused_images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, rjones@redhat.com, armbru@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This reuses the new bdrv_drop_intermediate. Signed-off-by: Fam Zheng --- block/stream.c | 30 +----------------------------- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/block/stream.c b/block/stream.c index dd0b4ac..9cdcf0e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -51,34 +51,6 @@ static int coroutine_fn stream_populate(BlockDriverState *bs, return bdrv_co_copy_on_readv(bs, sector_num, nb_sectors, &qiov); } -static void close_unused_images(BlockDriverState *top, BlockDriverState *base, - const char *base_id) -{ - BlockDriverState *intermediate; - intermediate = top->backing_hd; - - /* Must assign before bdrv_delete() to prevent traversing dangling pointer - * while we delete backing image instances. - */ - top->backing_hd = base; - - while (intermediate) { - BlockDriverState *unused; - - /* reached base */ - if (intermediate == base) { - break; - } - - unused = intermediate; - intermediate = intermediate->backing_hd; - unused->backing_hd = NULL; - bdrv_unref(unused); - } - - bdrv_refresh_limits(top); -} - static void coroutine_fn stream_run(void *opaque) { StreamBlockJob *s = opaque; @@ -192,7 +164,7 @@ wait: } } ret = bdrv_change_backing_file(bs, base_id, base_fmt); - close_unused_images(bs, base, base_id); + bdrv_drop_intermediate(bs, bs->backing_hd, base); } qemu_vfree(buf); -- 1.8.5.3