qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit.canet@irqsave.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] qemu-iotests: Add VM method qtest_cmd() to iotests.py
Date: Wed, 29 Jan 2014 16:40:41 +0800	[thread overview]
Message-ID: <1390984843-2101-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1390984843-2101-1-git-send-email-famz@redhat.com>

This will allow test case to run command in qtest protocol. It's
write-only for now.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/iotests.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index e4fa9af..ca79d09 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -153,13 +153,16 @@ class VM(object):
                              stderr=sys.stderr)
         return p.wait()
 
+    def qtest_cmd(self, cmd):
+        self._popen.stdin.write(cmd + "\n")
+
     def launch(self):
         '''Launch the VM and establish a QMP connection'''
-        devnull = open('/dev/null', 'rb')
         qemulog = open(self._qemu_log_path, 'wb')
         try:
             self._qmp = qmp.QEMUMonitorProtocol(self._monitor_path, server=True)
-            self._popen = subprocess.Popen(self._args, stdin=devnull, stdout=qemulog,
+            self._popen = subprocess.Popen(self._args, stdin=subprocess.PIPE,
+                                           stdout=qemulog,
                                            stderr=subprocess.STDOUT)
             self._qmp.accept()
         except:
-- 
1.8.5.3

  parent reply	other threads:[~2014-01-29  8:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  8:40 [Qemu-devel] [PATCH 0/4] qemu-iotests: Test case for IO throttling Fam Zheng
2014-01-29  8:40 ` [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write Fam Zheng
2014-01-29 14:11   ` Stefan Hajnoczi
2014-01-29 15:25   ` Benoît Canet
2014-01-29 15:58   ` Paolo Bonzini
2014-02-01 14:31     ` Fam Zheng
2014-02-02  0:20       ` Paolo Bonzini
2014-02-07  7:47         ` Fam Zheng
2014-01-29  8:40 ` Fam Zheng [this message]
2014-01-29 14:22   ` [Qemu-devel] [PATCH 2/4] qemu-iotests: Add VM method qtest_cmd() to iotests.py Stefan Hajnoczi
2014-02-01 15:23     ` Fam Zheng
2014-01-29  8:40 ` [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-01-29 14:09   ` Eric Blake
2014-02-01 15:31     ` Fam Zheng
2014-01-29 14:23   ` Stefan Hajnoczi
2014-01-29 15:29   ` Benoît Canet
2014-01-29  8:40 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: Add 080 for IO throttling Fam Zheng
2014-01-29 14:36   ` Stefan Hajnoczi
2014-01-29 14:45   ` Stefan Hajnoczi
2014-01-29 15:34   ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390984843-2101-3-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).