[Qemu-devel] [PATCH] tcg/s390: Remove sigill_handler

[Qemu-devel] [PATCH] tcg/s390: Remove sigill_handler

[Richard Henderson]

Commit c9baa30f42a87f61627391698f63fa4d1566d9d8 failed to
delete all of the relevant code, leading to Werrors about
unused symbols.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/s390/tcg-target.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index 248726e..907d9d1 100644
--- a/tcg/s390/tcg-target.c
+++ b/tcg/s390/tcg-target.c
@@ -2214,25 +2214,6 @@ static const TCGTargetOpDef s390_op_defs[] = {
     { -1 },
 };
 
-/* ??? Linux kernels provide an AUXV entry AT_HWCAP that provides most of
-   this information.  However, getting at that entry is not easy this far
-   away from main.  Our options are: start searching from environ, but
-   that fails as soon as someone does a setenv in between.  Read the data
-   from /proc/self/auxv.  Or do the probing ourselves.  The only thing
-   extra that AT_HWCAP gives us is HWCAP_S390_HIGH_GPRS, which indicates
-   that the kernel saves all 64-bits of the registers around traps while
-   in 31-bit mode.  But this is true of all "recent" kernels (ought to dig
-   back and see from when this might not be true).  */
-
-#include <signal.h>
-
-static volatile sig_atomic_t got_sigill;
-
-static void sigill_handler(int sig)
-{
-    got_sigill = 1;
-}
-
 static void query_facilities(void)
 {
     unsigned long hwcap = qemu_getauxval(AT_HWCAP);
-- 
1.8.5.3

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg/s390: Remove sigill_handler

[Michael Tokarev]

30.01.2014 01:08, Richard Henderson wrote:
> Commit c9baa30f42a87f61627391698f63fa4d1566d9d8 failed to
> delete all of the relevant code, leading to Werrors about
> unused symbols.

Applied to the trivial-patches queue, thank you!

/mjt