qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com, agraf@suse.de
Subject: [Qemu-devel] [PATCH v3 3/9] ide: Don't block-align IDEState member smart_selftest_data
Date: Thu, 30 Jan 2014 13:16:32 +0100	[thread overview]
Message-ID: <1391084198-21021-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1391084198-21021-1-git-send-email-armbru@redhat.com>

All uses are simple array subscripts.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ide/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index dcfd92d..6aaf6fa 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2164,8 +2164,7 @@ static void ide_init1(IDEBus *bus, int unit)
     s->io_buffer = qemu_memalign(2048, s->io_buffer_total_len);
     memset(s->io_buffer, 0, s->io_buffer_total_len);
 
-    s->smart_selftest_data = qemu_blockalign(s->bs, 512);
-    memset(s->smart_selftest_data, 0, 512);
+    s->smart_selftest_data = g_malloc0(512);
 
     s->sector_write_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,
                                            ide_sector_write_timer_cb, s);
-- 
1.8.1.4

  parent reply	other threads:[~2014-01-30 12:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 12:16 [Qemu-devel] [PATCH v3 0/9] Clean up IDE after completion of qdevification Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 1/9] ide: Move IDEDevice pointer from IDEBus to IDEState Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 2/9] ide: Use IDEState member dev for "device connected" test Markus Armbruster
2014-01-30 12:16 ` Markus Armbruster [this message]
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 4/9] ide: Drop redundant IDEState member bs Markus Armbruster
2014-02-03 14:54   ` Kevin Wolf
2014-02-05 14:07     ` Markus Armbruster
2014-02-05 17:09       ` Stefano Stabellini
2014-02-06  7:02         ` Markus Armbruster
2014-02-07 12:58           ` Stefano Stabellini
2014-02-11 14:41             ` Markus Armbruster
2014-02-12  9:16               ` Markus Armbruster
2014-02-12 13:48                 ` Stefano Stabellini
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 5/9] ide: Drop redundant IDEState geometry members Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 6/9] ide: Drop redundant IDEState member version Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 7/9] ide: Drop redundant IDEState member drive_serial_str Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 8/9] ide: Drop redundant IDEState member model Markus Armbruster
2014-01-30 12:16 ` [Qemu-devel] [PATCH v3 9/9] ide: Drop redundant IDEState member wwn Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391084198-21021-4-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).