From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8rNu-0005hy-UT for qemu-devel@nongnu.org; Thu, 30 Jan 2014 08:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8rNm-0003Cv-Et for qemu-devel@nongnu.org; Thu, 30 Jan 2014 08:10:22 -0500 Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:62635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8rNm-0003Cm-8H for qemu-devel@nongnu.org; Thu, 30 Jan 2014 08:10:14 -0500 Received: by mail-ee0-f46.google.com with SMTP id c13so1586146eek.33 for ; Thu, 30 Jan 2014 05:10:13 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 30 Jan 2014 14:09:47 +0100 Message-Id: <1391087394-17914-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> References: <1391087394-17914-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 05/12] qdev: legacy properties are just strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, afaerber@suse.de prop->info->legacy_name is still used by "-device foo,?". Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 7c1b732..482a978 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -590,7 +590,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v, void *opaque, void qdev_property_add_legacy(DeviceState *dev, Property *prop, Error **errp) { - gchar *name, *type; + gchar *name; /* Register pointer properties as legacy properties */ if (!prop->info->print && prop->info->get) { @@ -598,16 +598,12 @@ void qdev_property_add_legacy(DeviceState *dev, Property *prop, } name = g_strdup_printf("legacy-%s", prop->name); - type = g_strdup_printf("legacy<%s>", - prop->info->legacy_name ?: prop->info->name); - - object_property_add(OBJECT(dev), name, type, + object_property_add(OBJECT(dev), name, "str", prop->info->print ? qdev_get_legacy_property : prop->info->get, NULL, NULL, prop, errp); - g_free(type); g_free(name); } -- 1.8.4.2