[Qemu-devel] [PULL 0/1] libcacard glusterfs fix

[Qemu-devel] [PULL 0/1] libcacard glusterfs fix

[Alon Levy]

The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd:

  Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +0000)

are available in the git repository at:


  git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs

for you to fetch changes up to 02c783d9d356f3e6410e46fc3f96114024e3fc32:

  libcacard: Don't link with all libraries QEMU links to (2014-01-30 16:54:06 +0200)

----------------------------------------------------------------
Christophe Fergeau (1):
      libcacard: Don't link with all libraries QEMU links to

 libcacard/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.8.4.2

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

[Alon Levy]

From: Christophe Fergeau <cfergeau@redhat.com>

As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
libcacard currently links to all the libraries QEMU is linking to,
including glusterfs libraries, libiscsi, ... libcacard does not need all of
these. This patch ensures it's only linked with the libraries it needs.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
 libcacard/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcacard/Makefile b/libcacard/Makefile
index 4d15da4..6b06448 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
 
 libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
 	-export-syms $(SRC_PATH)/libcacard/libcacard.syms
-libcacard.la: LIBS += $(libcacard_libs)
+libcacard.la: LIBS = $(libcacard_libs)
 libcacard.la: $(libcacard-lobj-y)
 	$(call LINK,$^)
 
-- 
1.8.4.2

Re: [Qemu-devel] [PULL 0/1] libcacard glusterfs fix

[Peter Maydell]

On 30 January 2014 15:03, Alon Levy <alevy@redhat.com> wrote:
> The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd:
>
>   Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +0000)
>
> are available in the git repository at:
>
>
>   git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs
>
> for you to fetch changes up to 02c783d9d356f3e6410e46fc3f96114024e3fc32:
>
>   libcacard: Don't link with all libraries QEMU links to (2014-01-30 16:54:06 +0200)
>
> ----------------------------------------------------------------
> Christophe Fergeau (1):
>       libcacard: Don't link with all libraries QEMU links to
>
>  libcacard/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm afraid I can't apply this pull request. All the patches
in a pull should have your signoff as the subsystem maintainer,
indicating that they've passed through your hands and you're
happy with them. (They need the signoff of the original
contributor as well, of course.)

thanks
-- PMM