* [Qemu-devel] [PULL 0/1] libcacard glusterfs fix
@ 2014-01-30 15:03 Alon Levy
2014-01-30 15:03 ` [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to Alon Levy
2014-02-04 18:44 ` [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Alon Levy @ 2014-01-30 15:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd:
Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +0000)
are available in the git repository at:
git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs
for you to fetch changes up to 02c783d9d356f3e6410e46fc3f96114024e3fc32:
libcacard: Don't link with all libraries QEMU links to (2014-01-30 16:54:06 +0200)
----------------------------------------------------------------
Christophe Fergeau (1):
libcacard: Don't link with all libraries QEMU links to
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.4.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to
2014-01-30 15:03 [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Alon Levy
@ 2014-01-30 15:03 ` Alon Levy
2014-02-04 18:44 ` [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Alon Levy @ 2014-01-30 15:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori
From: Christophe Fergeau <cfergeau@redhat.com>
As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
libcacard currently links to all the libraries QEMU is linking to,
including glusterfs libraries, libiscsi, ... libcacard does not need all of
these. This patch ensures it's only linked with the libraries it needs.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 4d15da4..6b06448 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
-export-syms $(SRC_PATH)/libcacard/libcacard.syms
-libcacard.la: LIBS += $(libcacard_libs)
+libcacard.la: LIBS = $(libcacard_libs)
libcacard.la: $(libcacard-lobj-y)
$(call LINK,$^)
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL 0/1] libcacard glusterfs fix
2014-01-30 15:03 [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Alon Levy
2014-01-30 15:03 ` [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to Alon Levy
@ 2014-02-04 18:44 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2014-02-04 18:44 UTC (permalink / raw)
To: Alon Levy; +Cc: QEMU Developers, Anthony Liguori
On 30 January 2014 15:03, Alon Levy <alevy@redhat.com> wrote:
> The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd:
>
> Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +0000)
>
> are available in the git repository at:
>
>
> git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs
>
> for you to fetch changes up to 02c783d9d356f3e6410e46fc3f96114024e3fc32:
>
> libcacard: Don't link with all libraries QEMU links to (2014-01-30 16:54:06 +0200)
>
> ----------------------------------------------------------------
> Christophe Fergeau (1):
> libcacard: Don't link with all libraries QEMU links to
>
> libcacard/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I'm afraid I can't apply this pull request. All the patches
in a pull should have your signoff as the subsystem maintainer,
indicating that they've passed through your hands and you're
happy with them. (They need the signoff of the original
contributor as well, of course.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PULL 0/1 v2] libcacard glusterfs fix
@ 2014-02-09 11:13 Alon Levy
2014-02-09 11:13 ` [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to Alon Levy
0 siblings, 1 reply; 4+ messages in thread
From: Alon Levy @ 2014-02-09 11:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori
changes from v1: Added Signed-of by me.
The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707:
Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into staging (2014-02-08 15:57:51 +0000)
are available in the git repository at:
git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs
for you to fetch changes up to 73db416ae7941f8ffeabc060ec87402b97314b6d:
libcacard: Don't link with all libraries QEMU links to (2014-02-09 13:06:02 +0200)
----------------------------------------------------------------
Christophe Fergeau (1):
libcacard: Don't link with all libraries QEMU links to
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.5.3
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to
2014-02-09 11:13 [Qemu-devel] [PULL 0/1 v2] " Alon Levy
@ 2014-02-09 11:13 ` Alon Levy
0 siblings, 0 replies; 4+ messages in thread
From: Alon Levy @ 2014-02-09 11:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Anthony Liguori
From: Christophe Fergeau <cfergeau@redhat.com>
As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
libcacard currently links to all the libraries QEMU is linking to,
including glusterfs libraries, libiscsi, ... libcacard does not need all of
these. This patch ensures it's only linked with the libraries it needs.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 4d15da4..6b06448 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
-export-syms $(SRC_PATH)/libcacard/libcacard.syms
-libcacard.la: LIBS += $(libcacard_libs)
+libcacard.la: LIBS = $(libcacard_libs)
libcacard.la: $(libcacard-lobj-y)
$(call LINK,$^)
--
1.8.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-09 11:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-30 15:03 [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Alon Levy
2014-01-30 15:03 ` [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to Alon Levy
2014-02-04 18:44 ` [Qemu-devel] [PULL 0/1] libcacard glusterfs fix Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2014-02-09 11:13 [Qemu-devel] [PULL 0/1 v2] " Alon Levy
2014-02-09 11:13 ` [Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to Alon Levy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).