From: Orit Wasserman <owasserm@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Orit Wasserman <owasserm@redhat.com>,
dgilbert@redhat.com, anthony@codemonkey.ws, quintela@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size
Date: Thu, 30 Jan 2014 20:08:36 +0200 [thread overview]
Message-ID: <1391105318-23247-5-git-send-email-owasserm@redhat.com> (raw)
In-Reply-To: <1391105318-23247-1-git-send-email-owasserm@redhat.com>
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
migration.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/migration.c b/migration.c
index 46a7305..25add6f 100644
--- a/migration.c
+++ b/migration.c
@@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp)
return;
}
+ /* Cache should not be larger than guest ram size */
+ if (value > ram_bytes_total()) {
+ error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
+ "exceeds guest ram size ");
+ return;
+ }
+
new_size = xbzrle_cache_resize(value);
if (new_size < 0) {
error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
--
1.8.3.1
next prev parent reply other threads:[~2014-01-30 18:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 18:08 [Qemu-devel] [PATCH v2 0/6] XBZRLE Fixes Orit Wasserman
2014-01-30 18:08 ` [Qemu-devel] [PATCH v2 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors Orit Wasserman
2014-01-30 18:08 ` [Qemu-devel] [PATCH v2 2/6] Add check for cache size smaller than page size Orit Wasserman
2014-01-30 18:08 ` [Qemu-devel] [PATCH v2 3/6] migration:fix free XBZRLE decoded_buf wrong Orit Wasserman
2014-01-30 18:08 ` Orit Wasserman [this message]
2014-01-30 18:23 ` [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size Dr. David Alan Gilbert
2014-01-30 18:42 ` Orit Wasserman
2014-01-30 18:48 ` Dr. David Alan Gilbert
2014-01-30 18:59 ` Orit Wasserman
2014-01-30 18:45 ` Dr. David Alan Gilbert
2014-01-30 18:08 ` [Qemu-devel] [PATCH v2 5/6] Don't abort on out of memory when creating page cache Orit Wasserman
2014-01-30 18:21 ` Dr. David Alan Gilbert
2014-01-30 18:08 ` [Qemu-devel] [PATCH v2 6/6] Don't abort on memory allocation error Orit Wasserman
2014-01-30 18:17 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391105318-23247-5-git-send-email-owasserm@redhat.com \
--to=owasserm@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).