From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8w2O-0007ZL-Jz for qemu-devel@nongnu.org; Thu, 30 Jan 2014 13:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8w2H-0007bv-CY for qemu-devel@nongnu.org; Thu, 30 Jan 2014 13:08:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8w2H-0007bo-4K for qemu-devel@nongnu.org; Thu, 30 Jan 2014 13:08:21 -0500 From: Orit Wasserman Date: Thu, 30 Jan 2014 20:08:36 +0200 Message-Id: <1391105318-23247-5-git-send-email-owasserm@redhat.com> In-Reply-To: <1391105318-23247-1-git-send-email-owasserm@redhat.com> References: <1391105318-23247-1-git-send-email-owasserm@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Orit Wasserman , dgilbert@redhat.com, anthony@codemonkey.ws, quintela@redhat.com Signed-off-by: Orit Wasserman --- migration.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migration.c @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp) return; } + /* Cache should not be larger than guest ram size */ + if (value > ram_bytes_total()) { + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size", + "exceeds guest ram size "); + return; + } + new_size = xbzrle_cache_resize(value); if (new_size < 0) { error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size", -- 1.8.3.1