From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@amazon.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v3 0/5] pc: make ACPI pcihp more reusable
Date: Fri, 31 Jan 2014 14:27:05 +0100 [thread overview]
Message-ID: <1391174830-5866-1-git-send-email-imammedo@redhat.com> (raw)
changes since v2:
- rename 'use_acpi_pci_hotplug' field to 'legacy_piix'
and corresponding properties
- drop excessive checks for legacy mode
- rework legacy vmstate handling to use AcpiPciHpPciStatus[0] structure
which reduced acpi/piix4.c by another 50 LOC
- move legacy initialization to pcihp.c
changes since v1:
- add BSEL property to root bus when in compatibility mode
as result dropped "hw:acpi:pcihp: assume root PCI bus if bus has no ACPI_PCIHP_PROP_BSEL property"
- rebasing on top of "pcihp: reduce number of device check events"
added patch 3/4.
Reuses new pcihp code for handling legacy PCI hotplug in
acpi/piix4_pm, which significantly reduces code duplication
between piix4_pm and pcihp reducing codebase by ~200 LOC.
It also allows cleaner rebase of generic hotplug refactoring,
by not increasing code duplication since it will need to be
done only for pcihp.
Git tree for testing based on mst's PCI tree:
https://github.com/imammedo/qemu/commits/pcihp_cleanup_v3
Igor Mammedov (5):
pcihp: replace enable|disable_device() with oneliners
pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR
pcihp: make pci_read() mmio calback compatible with legacy ACPI
hotplug
pcihp: remove unused AcpiPciHpPciStatus.device_present field
hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug
hw/acpi/pcihp.c | 64 +++++++-------
hw/acpi/piix4.c | 220 ++++-------------------------------------------
include/hw/acpi/pcihp.h | 3 +-
include/hw/i386/pc.h | 4 +-
4 files changed, 57 insertions(+), 234 deletions(-)
next reply other threads:[~2014-01-31 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 13:27 Igor Mammedov [this message]
2014-01-31 13:27 ` [Qemu-devel] [PATCH v3 1/5] pcihp: replace enable|disable_device() with oneliners Igor Mammedov
2014-01-31 13:27 ` [Qemu-devel] [PATCH v3 2/5] pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR Igor Mammedov
2014-01-31 13:27 ` [Qemu-devel] [PATCH v3 3/5] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug Igor Mammedov
2014-02-02 17:06 ` Michael S. Tsirkin
2014-01-31 13:27 ` [Qemu-devel] [PATCH v3 4/5] pcihp: remove unused AcpiPciHpPciStatus.device_present field Igor Mammedov
2014-01-31 13:27 ` [Qemu-devel] [PATCH v3 5/5] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391174830-5866-1-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=aliguori@amazon.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).