qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: edgar.iglesias@gmail.com
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/6] cris: Abort when a v10 takes interrupts while in a delayslot
Date: Sun,  2 Feb 2014 03:04:48 +0000	[thread overview]
Message-ID: <1391310292-18008-3-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1391310292-18008-1-git-send-email-edgar.iglesias@gmail.com>

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

This is an internal error as the CRISv10 should mask interrupts
while executing delay slots. Bail out sooner rather than later.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target-cris/helper.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/target-cris/helper.c b/target-cris/helper.c
index d274b38..c940582 100644
--- a/target-cris/helper.c
+++ b/target-cris/helper.c
@@ -126,6 +126,11 @@ void crisv10_cpu_do_interrupt(CPUState *cs)
           env->exception_index,
           cs->interrupt_request);
 
+    if (env->dslot) {
+        /* CRISv10 never takes interrupts while in a delay-slot.  */
+        cpu_abort(env, "CRIS: Interrupt on delay-slot\n");
+    }
+
     assert(!(env->pregs[PR_CCS] & PFIX_FLAG));
     switch (env->exception_index) {
     case EXCP_BREAK:
-- 
1.8.3.2

  parent reply	other threads:[~2014-02-02  3:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-02  3:04 [Qemu-devel] [PATCH 0/6] CRIS queue edgar.iglesias
2014-02-02  3:04 ` [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default "any" CPU for user mode emulation edgar.iglesias
2014-02-03 11:02   ` Riku Voipio
2014-02-03 12:12     ` Edgar E. Iglesias
2014-02-03 11:44   ` Andreas Färber
2014-02-03 13:22     ` Edgar E. Iglesias
2014-02-02  3:04 ` edgar.iglesias [this message]
2014-02-02  3:04 ` [Qemu-devel] [PATCH 3/6] cris: Add interrupt signals to the CPU device edgar.iglesias
2014-02-02 23:54   ` Peter Crosthwaite
2014-02-02  3:04 ` [Qemu-devel] [PATCH 4/6] axis-dev88: Connect the PIC upstream IRQs directly to the CPU edgar.iglesias
2014-02-02 23:54   ` Peter Crosthwaite
2014-02-02  3:04 ` [Qemu-devel] [PATCH 5/6] cris: Remove the CRIS PIC glue edgar.iglesias
2014-02-02 23:54   ` Peter Crosthwaite
2014-02-02  3:04 ` [Qemu-devel] [PATCH 6/6] linux-user: Fix trampoline code for CRIS edgar.iglesias
2014-02-03 10:49   ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391310292-18008-3-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).