Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:71:init_socket:
> > assertion failed (ret != -1): (-1 != -1)
> > FAIL
> > GTester: last random seed: R02S79ea313790bc9a8b21d9af5ed55c2fff
> > (pid=5080)
> >   /i386/qom/pc:                                                        OK
> >   /i386/qom/isapc:                                                     OK
> >   /i386/qom/q35:                                                       OK
> > FAIL: tests/qom-test
> >
> > but this patch series doesn't actually say that's what it's for,
> > so does it fix that kind of error?
> 
> I might help but I'm not sure.  The assertion failure you posted
> happened on Gerd's buildslaves, I haven't reproduced it myself and
> don't really understand what's wrong there.

It seems to have stopped happening on the buildslaves,
not sure whenever this is just luck or whenever it was
fixed by some patch.

> However, I noticed that my /tmp is getting cluttered with pid files
> and UNIX domain sockets from qtest.  I also noticed that QEMU
> processes are left running (this is not fixed by my series) when tests
> fail.
> 
> So this series at least stops us from cluttering /tmp.

Removing the clutter from /tmp unbroke the buildslaves, so not
cluttering tmp certainly is a good thing.

cheers,
  Gerd