From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAFPD-0007dO-5c
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:01:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAFP7-0002ar-7o
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:01:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAFP6-0002am-Um
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:01:21 -0500
Message-ID: <1391418053.23350.36.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 03 Feb 2014 10:00:53 +0100
In-Reply-To: <CAJSP0QVzFiZkMqYBAupaczBs1PcXLii5qAxm7Kc2CrvPOjhSmw@mail.gmail.com>
References: <1385031835-4472-1-git-send-email-stefanha@redhat.com>
	<CAFEAcA9dcSOFYbfCEJGQF8gU3qGVhx3jjfyh8k1OLhqv94GehQ@mail.gmail.com>
	<CAJSP0QVzFiZkMqYBAupaczBs1PcXLii5qAxm7Kc2CrvPOjhSmw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX
 domain sockets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Andreas Faerber <afaerber@suse.de>

  Hi,

> > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:71:init_socket:
> > assertion failed (ret != -1): (-1 != -1)
> > FAIL
> > GTester: last random seed: R02S79ea313790bc9a8b21d9af5ed55c2fff
> > (pid=5080)
> >   /i386/qom/pc:                                                        OK
> >   /i386/qom/isapc:                                                     OK
> >   /i386/qom/q35:                                                       OK
> > FAIL: tests/qom-test
> >
> > but this patch series doesn't actually say that's what it's for,
> > so does it fix that kind of error?
> 
> I might help but I'm not sure.  The assertion failure you posted
> happened on Gerd's buildslaves, I haven't reproduced it myself and
> don't really understand what's wrong there.

It seems to have stopped happening on the buildslaves,
not sure whenever this is just luck or whenever it was
fixed by some patch.

> However, I noticed that my /tmp is getting cluttered with pid files
> and UNIX domain sockets from qtest.  I also noticed that QEMU
> processes are left running (this is not fixed by my series) when tests
> fail.
> 
> So this series at least stops us from cluttering /tmp.

Removing the clutter from /tmp unbroke the buildslaves, so not
cluttering tmp certainly is a good thing.

cheers,
  Gerd