From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAG4b-0008Pa-8B
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:44:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAG4U-0006jh-W8
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:44:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38493)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WAG4U-0006jb-O4
	for qemu-devel@nongnu.org; Mon, 03 Feb 2014 04:44:06 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s139i5Nt026391
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 3 Feb 2014 04:44:05 -0500
Message-ID: <1391420641.23350.45.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 03 Feb 2014 10:44:01 +0100
In-Reply-To: <52EAEDA9.7070802@redhat.com>
References: <1390903055-479-1-git-send-email-kraxel@redhat.com>
	<1390903055-479-7-git-send-email-kraxel@redhat.com>
	<52EAEDA9.7070802@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

> s/alot/a lot/

> s/splitted/split/

Applied.

> > +##
> > +# @InputBtnEvent
> 
> Should we spell this out?  I'm okay with the abbreviation if it makes it
> easier to fit 80 columns, but Button is nicer to read than Btn.

I'm sort-of following linux input layer convention here,
which uses btn for the buttons too.

cheers,
  Gerd