qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 06/16] target-i386: kvm_cpu_fill_host(): Fill feature words in a loop
Date: Mon,  3 Feb 2014 17:39:01 +0100	[thread overview]
Message-ID: <1391445551-6561-7-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1391445551-6561-1-git-send-email-pbonzini@redhat.com>

From: Eduardo Habkost <ehabkost@redhat.com>

Now that the kvm_cpu_fill_host() code is simplified, we can simply set
the feature word array using a simple loop.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target-i386/cpu.c | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 237af97..200ad42 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1166,22 +1166,13 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
 
     cpu_x86_fill_model_id(x86_cpu_def->model_id);
 
-    x86_cpu_def->features[FEAT_1_EDX] =
-        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_EDX);
-    x86_cpu_def->features[FEAT_1_ECX] =
-        kvm_arch_get_supported_cpuid(s, 0x1, 0, R_ECX);
-    x86_cpu_def->features[FEAT_7_0_EBX] =
-        kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EBX);
-    x86_cpu_def->features[FEAT_8000_0001_EDX] =
-        kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_EDX);
-    x86_cpu_def->features[FEAT_8000_0001_ECX] =
-        kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_ECX);
-    x86_cpu_def->features[FEAT_C000_0001_EDX] =
-        kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX);
-    x86_cpu_def->features[FEAT_SVM] =
-        kvm_arch_get_supported_cpuid(s, 0x8000000A, 0, R_EDX);
-    x86_cpu_def->features[FEAT_KVM] =
-        kvm_arch_get_supported_cpuid(s, KVM_CPUID_FEATURES, 0, R_EAX);
+    FeatureWord w;
+    for (w = 0; w < FEATURE_WORDS; w++) {
+        FeatureWordInfo *wi = &feature_word_info[w];
+        x86_cpu_def->features[w] =
+            kvm_arch_get_supported_cpuid(s, wi->cpuid_eax, wi->cpuid_ecx,
+                                         wi->cpuid_reg);
+    }
 
 #endif /* CONFIG_KVM */
 }
-- 
1.8.3.1

  parent reply	other threads:[~2014-02-03 16:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 16:38 [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03 Paolo Bonzini
2014-02-03 16:38 ` [Qemu-devel] [PULL 01/16] target-i386: kvm_cpu_fill_host(): Kill unused code Paolo Bonzini
2014-02-03 16:38 ` [Qemu-devel] [PULL 02/16] target-i386: kvm_cpu_fill_host(): No need to check level Paolo Bonzini
2014-02-03 16:38 ` [Qemu-devel] [PULL 03/16] target-i386: kvm_cpu_fill_host(): No need to check CPU vendor Paolo Bonzini
2014-02-03 16:38 ` [Qemu-devel] [PULL 04/16] target-i386: kvm_cpu_fill_host(): No need to check xlevel2 Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 05/16] target-i386: kvm_cpu_fill_host(): Set all feature words at end of function Paolo Bonzini
2014-02-03 16:39 ` Paolo Bonzini [this message]
2014-02-03 16:39 ` [Qemu-devel] [PULL 07/16] target-i386: kvm_check_features_against_host(): Kill feature word array Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 08/16] kvm: print suberror on all internal errors Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 09/16] KVM: fix coexistence of KVM and Hyper-V leaves Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 10/16] kvm: make availability of Hyper-V enlightenments dependent on KVM_CAP_HYPERV Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 11/16] kvm: make hyperv hypercall and guest os id MSRs migratable Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 12/16] kvm: make hyperv vapic assist page migratable Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 13/16] kvm: add support for hyper-v timers Paolo Bonzini
2014-03-04 15:14   ` Peter Maydell
2014-02-03 16:39 ` [Qemu-devel] [PULL 14/16] target-i386: Eliminate CONFIG_KVM #ifdefs Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 15/16] target-i386: Don't change x86_def_t struct on cpu_x86_register() Paolo Bonzini
2014-02-03 16:39 ` [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init Paolo Bonzini
2014-02-08 17:28   ` Andreas Färber
2014-02-08 23:33     ` Paolo Bonzini
2014-02-09  0:10       ` Peter Maydell
2014-02-09  0:23         ` Peter Maydell
2014-02-09  6:57           ` Paolo Bonzini
2014-02-09  8:25             ` [Qemu-devel] [PATCH] target-i386: Don't declare variables in the middle of blocks Eduardo Habkost
2014-02-19 19:39               ` [Qemu-devel] [qom-cpu PATCH v2] " Eduardo Habkost
2014-02-20 12:48                 ` Andreas Färber
2014-02-09  8:06         ` [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init Eduardo Habkost
2014-02-09 10:13           ` Andreas Färber
2014-02-09 13:06           ` Peter Maydell
2014-02-09  1:41       ` Andreas Färber
2014-02-09  6:52         ` Paolo Bonzini
2014-02-06 11:12 ` [Qemu-devel] [PULL 00/16] KVM changes for 2014-02-03 Peter Maydell
2014-02-06 23:41   ` Paolo Bonzini
2014-02-07  0:03     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391445551-6561-7-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).