From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit@irqsave.net>,
stefanha@redhat.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH V15 07/13] quorum: Add quorum_getlength().
Date: Mon, 3 Feb 2014 22:51:14 +0100 [thread overview]
Message-ID: <1391464280-25627-8-git-send-email-benoit.canet@irqsave.net> (raw)
In-Reply-To: <1391464280-25627-1-git-send-email-benoit.canet@irqsave.net>
From: Benoît Canet <benoit@irqsave.net>
Check that every bs file returns the same length.
Otherwise, return -EIO to disable the quorum and
avoid length discrepancy.
Signed-off-by: Benoit Canet <benoit@irqsave.net>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/quorum.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index 837d261..2f302b4 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -585,12 +585,38 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverState *bs,
return &acb->common;
}
+static int64_t quorum_getlength(BlockDriverState *bs)
+{
+ BDRVQuorumState *s = bs->opaque;
+ int64_t result;
+ int i;
+
+ /* check that all file have the same length */
+ result = bdrv_getlength(s->bs[0]);
+ if (result < 0) {
+ return result;
+ }
+ for (i = 1; i < s->total; i++) {
+ int64_t value = bdrv_getlength(s->bs[i]);
+ if (value < 0) {
+ return value;
+ }
+ if (value != result) {
+ return -EIO;
+ }
+ }
+
+ return result;
+}
+
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
.protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState),
+ .bdrv_getlength = quorum_getlength,
+
.bdrv_aio_readv = quorum_aio_readv,
.bdrv_aio_writev = quorum_aio_writev,
};
--
1.8.3.2
next prev parent reply other threads:[~2014-02-03 21:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 21:51 [Qemu-devel] [PATCH V15 00/13] Quorum block filter Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB Benoît Canet
2014-02-04 12:57 ` Kevin Wolf
2014-02-05 13:29 ` Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init Benoît Canet
2014-02-04 13:08 ` Kevin Wolf
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 03/13] quorum: Add quorum_aio_writev and its dependencies Benoît Canet
2014-02-04 13:57 ` Kevin Wolf
2014-02-05 14:14 ` Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify Benoît Canet
2014-02-04 14:04 ` Kevin Wolf
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 05/13] quorum: Add quorum_aio_readv Benoît Canet
2014-02-04 14:15 ` Kevin Wolf
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 06/13] quorum: Add quorum mechanism Benoît Canet
2014-02-04 15:40 ` Kevin Wolf
2014-02-05 15:14 ` Benoît Canet
2014-02-03 21:51 ` Benoît Canet [this message]
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 08/13] quorum: Add quorum_invalidate_cache() Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 09/13] quorum: Add quorum_co_get_block_status Benoît Canet
2014-02-04 15:49 ` Kevin Wolf
2014-02-05 16:28 ` Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 10/13] quorum: Add quorum_co_flush() Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 11/13] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 12/13] quorum: Add quorum_open() and quorum_close() Benoît Canet
2014-02-04 16:08 ` Kevin Wolf
2014-02-05 16:11 ` Benoît Canet
2014-02-03 21:51 ` [Qemu-devel] [PATCH V15 13/13] quorum: Add unit test Benoît Canet
2014-02-04 16:13 ` Kevin Wolf
2014-02-04 21:53 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391464280-25627-8-git-send-email-benoit.canet@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).